Guard --reissue against unknown CNs and leftover build files
Code review findings on the "skip revoke when .crt is missing" migration path: - CliRunner._issue() took the skip path whenever has_issued_cert() was False, which is also true for a typo'd/nonexistent CN — it would warn, skip the revoke, and go on to build, package, and email a brand-new certificate for a CN nobody asked to renew. The skip now only fires when the CN has a current index.txt entry (via _load_current_certs()); an unknown CN prints an error and exits 1 with nothing built. The TUI's _process_cert() doesn't need the same guard — renewal there always opens on an existing row (cn_readonly pins the CN), so a typo'd CN can't reach the branch. - Skipping the revoke leaves pki/reqs/<CN>.req and pki/private/<CN>.key in place (normally revoke-issued archives both), which makes EasyRSA's build-client-full abort. Both CliRunner._issue() and CursesApp._process_cert() now check for those leftovers before building and fail fast with the exact paths, rather than surfacing EasyRSA's confusing error after the CA passphrase prompt. Neither path touches the files itself. Also: strengthened two under-specified tests (test_main_rejects_bad_days_flag now checks the resolver's message text, not just "--days", which also appears in argparse's unrelated error; test_show_cert_form_confirm now pins the Enter-keypress count so a partial "days" field reversion is caught), and folded a malformed CLAUDE.md table row into its neighbor. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -134,6 +134,11 @@ def test_show_cert_form_confirm():
|
||||
assert result.email == "bob@example.com"
|
||||
assert result.days == "90"
|
||||
assert len(result.password) > 0
|
||||
# Pins the field count itself: a partial reversion that drops "days"
|
||||
# from _FORM_FIELDS while CertFormResult/_submit() keep it would still
|
||||
# round-trip days="90" above (it's passed straight through, untraversed),
|
||||
# but would only consume 4 Enters, not 5.
|
||||
assert win.getch.call_count == 5
|
||||
|
||||
|
||||
def test_show_cert_form_cancel_button():
|
||||
|
||||
Reference in New Issue
Block a user