mirror of
https://github.com/nestriness/nestri.git
synced 2026-11-20 05:59:50 +02:00
fix(api): the same game added to a run twice is one launch (#426)
Follow-up to #422, from the nesktop #3 review. POST /session/{id}/launch for a game that already has an open launch (requested or running, no stop requested) in the run now answers that launch with 200 instead of inserting a second one. The check runs under the run's row lock that addLaunch already takes, so two concurrent adds resolve to one launch. OpenAPI documents the 200. Tested: apps/api 208 pass against the local test Postgres, including a new test adding the same game twice concurrently.
This commit is contained in:
@@ -226,6 +226,16 @@ describe('launches', () => {
|
||||
expect(run.launches.map((l: any) => l.state)).toEqual(['running', 'running']);
|
||||
});
|
||||
|
||||
test('the same game added twice is one launch', async () => {
|
||||
const { s, id, second } = await liveRun('launch-dedupe', 7109);
|
||||
const [a, b] = await Promise.all([addLaunch(s, id, second), addLaunch(s, id, second)]);
|
||||
const statuses = [a.status, b.status].sort();
|
||||
expect(statuses).toEqual([200, 201]);
|
||||
const ids = [((await a.json()) as any).data.id, ((await b.json()) as any).data.id];
|
||||
expect(ids[0]).toBe(ids[1]);
|
||||
expect((await read(s, id)).launches.length).toBe(2);
|
||||
});
|
||||
|
||||
test('a run that is not running takes no launch', async () => {
|
||||
const s = await scene('launch-notrunning', 7102);
|
||||
const { body } = await requestSession(s);
|
||||
|
||||
Reference in New Issue
Block a user