mirror of
https://github.com/nestriness/nestri.git
synced 2026-09-19 17:25:19 +03:00
refactor(api)!: remove the shared operator secret, and let hosts sync their own
A single secret that turned any request into an operator was the only credential several routes accepted, and it had no caller left: the device pairing it existed for is on hold, and nothing in this tree or any client sent it. What remained was a key that bypassed authentication entirely, required to boot, and checked by nobody. Every route behind it had a better answer available: - Library and game sync move to host credentials. Both took a `userId` in the body, which meant one secret could write into anybody's library. A host now says which of its enrolled users a batch is for, and that claim is checked against the Steam sign-ins it actually holds — one box carries several people's accounts, so the pair is the unit. - Download-state reporting narrows to hosts alone, and the body that could name a different host is gone. Which host is reporting comes from its own credentials, and a body that still names one is refused rather than ignored. - Linking a Steam account is always for the caller. - Creating a game by hand is deleted; syncing already upserts the catalogue. - Reading the waitlist is deleted. Every address on it belongs to someone who has not agreed to anything, and answering it over HTTP made that list something a leaked key could drain. - The pairing-code routes are deleted with the flow they served. The domain module and its table stay, so returning to it is a route file rather than a migration. Nothing in the API now accepts a credential that stands for more than one caller: every request resolves to a specific user or a specific host, which is what lets a route say "the caller's own library" and mean it. BREAKING CHANGE: the `x-nestri-admin-token` header is no longer accepted and `ADMIN_SHARED_SECRET` is no longer read. `POST /games`, `GET /waitlist` and the `/pairing-code` routes are gone; `POST /games/sync` and `POST /library/sync` now require host credentials and take `userId` in the body; `POST /steam/link` no longer accepts `userId`; `POST /games/download-state` no longer accepts `hostId`.
This commit is contained in:
3
.github/workflows/release-prod.yml
vendored
3
.github/workflows/release-prod.yml
vendored
@@ -138,7 +138,6 @@ jobs:
|
||||
PORT=13999 HOST=127.0.0.1 \
|
||||
DATABASE_URL="postgres://nobody@127.0.0.1:1/none" \
|
||||
AUTH_ISSUER_URL=https://auth.nestri.io \
|
||||
ADMIN_SHARED_SECRET=smoke \
|
||||
./dist/nestri-api & api=$!
|
||||
# NOT `/`, which the issuer answers 404 — it has no root route. NOT
|
||||
# `openid-configuration` either, also a 404: this is an OAuth 2.0
|
||||
@@ -168,7 +167,7 @@ jobs:
|
||||
# 127.0.0.1, and a connection string containing it would satisfy the
|
||||
# grep from the wrong line.
|
||||
env -u HOST PORT=13997 DATABASE_URL="postgres://nobody@nowhere.invalid:1/none" \
|
||||
ADMIN_SHARED_SECRET=smoke ./dist/nestri-api > /tmp/bind.log 2>&1 & probe=$!
|
||||
./dist/nestri-api > /tmp/bind.log 2>&1 & probe=$!
|
||||
sleep 3
|
||||
kill $probe 2>/dev/null || true
|
||||
grep -q "listening on http://127.0.0.1:" /tmp/bind.log || {
|
||||
|
||||
Reference in New Issue
Block a user