From 5f2ccdfbf25462731aef65184b6884d54c3b2f63 Mon Sep 17 00:00:00 2001 From: Wanjohi Date: Thu, 15 Oct 2026 00:41:30 +0300 Subject: [PATCH] fix(nesinit): let a game reserve more address space than the box has RAM The kernel's default overcommit policy refuses any single allocation larger than RAM plus swap. A box has no swap, so the ceiling is the box's own size, and an engine or driver that reserves address space it never touches is refused before it uses any of it. Dome Keeper asked for 9 GiB on an 8 GiB box and never started. Set vm.overcommit_memory=1 alongside vm.max_map_count, so a request is granted and the OOM killer acts on what is actually used. In a box that is the game: init has already exempted itself. --- apps/nesinit/src/system.rs | 42 +++++++++++++++++++++++++++++++++----- 1 file changed, 37 insertions(+), 5 deletions(-) diff --git a/apps/nesinit/src/system.rs b/apps/nesinit/src/system.rs index 5a952c9a..8246b58a 100644 --- a/apps/nesinit/src/system.rs +++ b/apps/nesinit/src/system.rs @@ -219,11 +219,26 @@ fn devices() { /// or Wine, and the process dies — here as a `wineserver crashed` with the game /// already gone. SteamOS and every distribution that packages Proton raise it /// to this value for that reason. -const SYSCTLS: &[(&str, &str, &str)] = &[( - "vm/max_map_count", - "2147483642", - "a game that maps more than 65530 regions (Unreal Engine 5 does) dies on a failed allocation", -)]; +/// - `vm.overcommit_memory`: **the kernel's default refuses any one allocation +/// larger than RAM plus swap**, and a box has no swap, so the ceiling is the +/// box's size: 8 GiB at 1080p. Engines and drivers reserve address space far +/// past what they touch, and a reservation is refused before a byte of it is +/// used — Dome Keeper asked for 9 GiB on an 8 GiB box and never started +/// (2026-10-14). `1` grants every request and leaves the OOM killer to act on +/// what is actually used; in a box that is the game, since this process has +/// already refused it. +const SYSCTLS: &[(&str, &str, &str)] = &[ + ( + "vm/max_map_count", + "2147483642", + "a game that maps more than 65530 regions (Unreal Engine 5 does) dies on a failed allocation", + ), + ( + "vm/overcommit_memory", + "1", + "a game that reserves more address space than the box has RAM is refused it and does not start", + ), +]; /// How many files a process may hold open, which every process in the box /// inherits from here. @@ -678,6 +693,23 @@ mod tests { assert!("2147483642".parse::().unwrap() > 65530 * 1000); } + #[test] + fn a_reservation_bigger_than_the_box_is_granted() { + let root = scratch("overcommit"); + std::fs::create_dir_all(root.join("vm")).unwrap(); + std::fs::write(root.join("vm/overcommit_memory"), "0\n").unwrap(); + + apply_sysctls(&root); + + assert_eq!( + std::fs::read_to_string(root.join("vm/overcommit_memory")) + .unwrap() + .trim(), + "1" + ); + let _ = std::fs::remove_dir_all(&root); + } + /// A box on a kernel without the knob still boots; the cost is said, not /// raised. #[test]