From aaa1bbd0f488be3818fabddad0a4ea235816db0b Mon Sep 17 00:00:00 2001 From: Wanjohi Date: Thu, 3 Sep 2026 22:40:36 +0300 Subject: [PATCH] fix(nesdoctor): the closing prose still said "launch times" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Missed when the histogram was corrected: the tool spent a paragraph asking people to send the JSON and described it as holding "installed titles with sizes and launch times", which is the same claim the histogram itself no longer makes. Steam stores when a title was last played, not each time it was launched. Found by running the installer end to end after the release — the shipped 0.3.0 binary prints it. Fixed here for the next one; it is prose in the closing paragraph, not a number anybody acted on. Same wording in the --json flag's doc comment, in the submit URL's comment, and in the consent prompt that asks to read the library at all. That last one matters most of the four: it is what somebody reads before saying yes. --- apps/nesdoctor/src/ask.rs | 2 +- apps/nesdoctor/src/main.rs | 10 +++++----- apps/nesdoctor/src/report.rs | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/apps/nesdoctor/src/ask.rs b/apps/nesdoctor/src/ask.rs index 936c2fdb..7f845b9c 100644 --- a/apps/nesdoctor/src/ask.rs +++ b/apps/nesdoctor/src/ask.rs @@ -148,7 +148,7 @@ pub fn run(ctx: &Ctx) -> Answers { println!( "\x1b[1mOne permission.\x1b[0m Steam keeps, on this disk, the size of each game you" ); - println!("have installed and the time you last launched it. Reading it answers three"); + println!("have installed and when you last played it. Reading it answers three"); println!("things we would otherwise have to ask you badly: how big a library is, what"); println!("shape it has, and what hours you actually play."); println!(); diff --git a/apps/nesdoctor/src/main.rs b/apps/nesdoctor/src/main.rs index 94da1b53..5759e0ba 100644 --- a/apps/nesdoctor/src/main.rs +++ b/apps/nesdoctor/src/main.rs @@ -78,7 +78,7 @@ struct Args { /// /// Relative to the working directory, which during development is a git /// checkout -- and this file contains the operator's own machine: home - /// paths, installed titles, launch times. It was committed to the public + /// paths, installed titles, when each was last played. It was committed to the public /// repository once by accident. `.gitignore` now covers the default name, /// and the default is deliberately not something like `report.json` that /// an ignore rule would miss. @@ -299,15 +299,15 @@ fn main() { args.json.display() ); println!( - "\x1b[2m full latency series, and your installed titles with sizes and launch\x1b[0m" + "\x1b[2m full latency series, and your installed titles with sizes and when\x1b[0m" ); println!( - "\x1b[2m times. It is more useful to us than anything above, because it is what\x1b[0m" + "\x1b[2m each was last played. It is more useful to us than anything above,\x1b[0m" ); println!( - "\x1b[2m lets us size a real game library. Have a read and send it along if\x1b[0m" + "\x1b[2m because it is what lets us size a real game library. Have a read and\x1b[0m" ); - println!("\x1b[2m nothing in there bothers you.\x1b[0m"); + println!("\x1b[2m send it along if nothing in there bothers you.\x1b[0m"); } // The one thing we can never ask afterwards. diff --git a/apps/nesdoctor/src/report.rs b/apps/nesdoctor/src/report.rs index a329c8b2..42d13346 100644 --- a/apps/nesdoctor/src/report.rs +++ b/apps/nesdoctor/src/report.rs @@ -417,7 +417,7 @@ fn enc(s: &str) -> String { /// /// Carries more than the clipboard line does, because it is not something /// anyone has to eyeball in a chat window: every check individually, the full -/// latency triple, the 24-hour launch histogram, and the five largest titles. +/// latency triple, the 24-hour last-played histogram, and the five largest titles. pub fn submit_url(base: &str, f_: &Full) -> String { let (sys, host, net, steam, answers, verdict, region) = ( f_.sys,