mirror of
https://github.com/nestriness/nestri.git
synced 2026-09-19 09:15:19 +03:00
fix(deploy): require every credential, and give sandbox its own domain
Three things review caught, and one shape correction. **No credential has a default any more.** The compose file shipped `ADMIN_SHARED_SECRET` falling back to a value written in this repository — and that header bypasses token verification entirely, so anyone reading the file could act as an operator against any deployment that had not overridden it. A default is worth less than it looks here: the deployment that never set the variable is exactly the one where the default is public. Every credential now comes from `.env`, and compose refuses to start naming the variable it wanted. That also takes the last literal password out of a tracked file. **The origin ports are on loopback.** Both services speak plain HTTP and mark no cookie `Secure`, because both expect to sit behind something that terminates TLS. Published on every interface they were a way to reach the issuer around that proxy, with sign-in codes and tokens in clear text. **Mail settings are passed through rather than fixed.** The issuer was pinned to printing sign-in codes to its log, and the three delivery settings never reached it — so the documented way to configure mail could not work, and every code and recipient went to the container log instead. Printing codes is now asked for in `.env` like everything else, and with nothing configured the issuer refuses to send rather than logging. **Sandbox becomes a domain rather than a prefix.** `api.sandbox.nestri.io` and `auth.sandbox.nestri.io`, because sandbox holds whatever is not production and that set grows. One certificate for `*.sandbox.nestri.io` then covers all of it, including unpredictable per-pull-request names, and cannot be presented for production's own domain — which the zone-wide wildcard the previous shape leaned on could. Also drops `STEAM_API_KEY`. It was declared in two type definitions and read by nothing: linking an account makes no outbound call that needs it.
This commit is contained in:
@@ -23,6 +23,7 @@ Hostnames, and why they are shaped the way they are: [`dns.md`](dns.md).
|
||||
Three ways, in increasing order of how much they resemble a deployment.
|
||||
|
||||
```sh
|
||||
cp .env.example .env # once; compose has no credentials of its own
|
||||
docker compose up postgres # the database, for either of the next two
|
||||
bun dev # both apps under the Workers runtime
|
||||
bun run dev:server # both apps as plain processes
|
||||
@@ -90,10 +91,14 @@ bunx wrangler secret put EMAIL_API_KEY --env production
|
||||
bunx wrangler secret put EMAIL_FROM --env production
|
||||
|
||||
cd ../api
|
||||
bunx wrangler secret put STEAM_API_KEY --env production
|
||||
bunx wrangler secret put ADMIN_SHARED_SECRET --env production
|
||||
```
|
||||
|
||||
`ADMIN_SHARED_SECRET` turns any request carrying it into an operator, so
|
||||
generate it rather than choosing it — `openssl rand -hex 32` — and never give
|
||||
it a default anywhere. What it is for is listed in
|
||||
[`apps/api/README.md`](../apps/api/README.md).
|
||||
|
||||
The issuer refuses to send a sign-in code with its mail settings half
|
||||
configured or absent, rather than falling back to printing codes to the log —
|
||||
so a deployment that forgets these fails at the first sign-in attempt with a
|
||||
@@ -134,14 +139,16 @@ Both images are stateless and hold no configuration. What they need:
|
||||
| `AUTH_INTERNAL_URL` | — | only if that URL is unroutable from here |
|
||||
| `EMAIL_SEND_URL` `EMAIL_API_KEY` `EMAIL_FROM` | all three, or none | — |
|
||||
| `EMAIL_DEV_LOG` | `true` prints codes instead of sending | — |
|
||||
| `STEAM_API_KEY` | — | to link a Steam account |
|
||||
| `ADMIN_SHARED_SECRET` | — | operator access |
|
||||
| `ADMIN_SHARED_SECRET` | — | required; operator access |
|
||||
| `PORT` | default `1337` | default `3000` |
|
||||
|
||||
[`docker-compose.yml`](../docker-compose.yml) at the root wires all of it
|
||||
together with a Postgres, and is the smallest complete answer to *"how do I run
|
||||
this myself"*.
|
||||
|
||||
Neither image terminates TLS or serves a certificate. Put a reverse proxy in
|
||||
front of them, point the hostnames at it, and keep the origin unreachable
|
||||
except through it.
|
||||
Neither image terminates TLS or serves a certificate, and neither marks the
|
||||
cookies it sets `Secure`, because both expect to sit behind something that does
|
||||
terminate TLS. So put a reverse proxy in front of them and keep the origin
|
||||
unreachable except through it — `docker-compose.yml` publishes their ports on
|
||||
loopback only for exactly this reason, and changing that to `0.0.0.0` is a way
|
||||
to reach the issuer *around* the proxy with codes and tokens in clear text.
|
||||
|
||||
Reference in New Issue
Block a user