release-nesdoctor.yml
Four targets on tag `nesdoctor-v*`: x86_64 linux-musl, x86_64 windows-msvc,
aarch64 and x86_64 macOS. musl rather than glibc so one Linux binary runs on
every distro regardless of glibc version. SHA256SUMS beside the binaries,
because "download this and run it" is only a reasonable request if the file
can be verified. `fail-fast: false` -- a Windows failure should still leave
the Linux binary available to look at.
Built here and nowhere else: a binary somebody produced on their laptop and
uploaded is not auditable however honest they are.
The step that justifies the workflow is the smoke test, which runs the
binary it just built, network included. `ring` under rustls resolves root
certificates through the host trust store, so a static musl build can compile
cleanly and then fail TLS on the machine it ships to -- breaking the network
test, the one feature anybody runs this for, silently and only for other
people. The step fails the build if the summary line comes back
`net=unmeasured`.
A manual dispatch builds and smoke-tests without publishing, which is what
you want while iterating.
ci.yml
A `nesdoctor` job: fmt, clippy -D warnings, test, and one real run. Scoped to
the one member deliberately -- the rest of the Rust half has never been under
CI, so `--workspace` would turn every PR red for unrelated reasons. Widen it
one member at a time as each is made to pass.
Two bugs the new gates found immediately, both of which shipped in the previous
commit:
- `--quiet` printed the whole questionnaire before its summary line, which
breaks the one thing `--quiet` promises. Prompts are now skipped when
stdout is quiet or stdin is not a terminal -- and a pipe is explicitly not
treated as consent to read somebody's Steam library, unlike `--yes`.
- clippy: an `if` with identical branches in the KVM check, two map
iterations taking keys they discarded, a manual `split_once`, and a
`sort_by` that wanted `sort_by_key`. `needless_return` is allowed in
`sys.rs` with the reason stated: every probe there is a stack of
cfg-gated returns and the trailing `return` in each arm is load-bearing.
Squashes the current state of the internal working tree onto this history.
The two trees had grown apart with no common ancestor, so this is a content
sync rather than a merge, and the published history is preserved rather than
rewritten — a force-push here would break every existing fork and clone to no
benefit.
What lands:
- Waitlist: API route, core module, and migration 0006 alongside game aliases.
- User verification.
- CI, oxfmt config, editor settings.
- Assorted fixes across the API routes and core modules.
The repository's own README, the wordmark and the per-package READMEs are kept
from this side; the internal tree had dropped them and they are what a stranger
arriving here reads first.
The marketing site in the internal tree is deliberately not here. It is a
separate product with its own repo and its own licence, and this repo is the
open one — a closed component does not belong in it regardless of how convenient
the directory looked.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
