fix(yahoo): print each fundamentals money figure with the currency it is in (#1456)

- price levels carry the quote currency (GBp for London), market cap and per-share figures its main unit (GBP), and income figures the reporting currency (TWD for TSMC's ADR)
This commit is contained in:
Yijia-Xiao
2026-10-03 21:27:43 +00:00
parent 5ca37b5088
commit 810b4cc48d
2 changed files with 70 additions and 13 deletions
+40
View File
@@ -37,3 +37,43 @@ def test_an_absent_percent_field_is_left_out():
out = _fundamentals({"longName": "JPMorgan Chase & Co.", "profitMargins": 0.35})
assert "Dividend Yield" not in out and "Debt to Equity" not in out
@pytest.mark.unit
def test_each_money_figure_carries_the_currency_it_is_in():
"""Yahoo quotes London in pence but states EPS and market cap in pounds, and
the income figures in the reporting currency (#1456)."""
out = _fundamentals({"longName": "Shell plc", "currency": "GBp", "financialCurrency": "USD",
"marketCap": 203440193536, "trailingEps": 3.42, "bookValue": 29.1,
"fiftyTwoWeekHigh": 3800.0, "fiftyDayAverage": 3500.5,
"totalRevenue": 296600993792, "netIncomeToCommon": 25970999296})
assert "Market Cap: 203440193536 GBP" in out
assert "EPS (TTM): 3.42 GBP" in out and "Book Value: 29.1 GBP" in out
assert "52 Week High: 3800.0 GBp" in out and "50 Day Average: 3500.5 GBp" in out
assert "Revenue (TTM): 296600993792 USD" in out and "Net Income: 25970999296 USD" in out
@pytest.mark.unit
def test_an_adr_quotes_in_dollars_and_reports_in_its_home_currency():
out = _fundamentals({"longName": "TSMC", "currency": "USD", "financialCurrency": "TWD",
"marketCap": 2365000000000, "trailingEps": 13.21, "totalRevenue": 4440492343296})
assert "Market Cap: 2365000000000 USD" in out and "EPS (TTM): 13.21 USD" in out
assert "Revenue (TTM): 4440492343296 TWD" in out
@pytest.mark.unit
def test_a_figure_with_no_stated_currency_is_printed_bare():
out = _fundamentals({"longName": "X", "marketCap": 1000, "totalRevenue": 50})
assert "Market Cap: 1000\n" in out + "\n" and "Revenue (TTM): 50" in out and "None" not in out
@pytest.mark.unit
def test_income_figures_without_a_stated_reporting_currency_are_printed_bare():
"""The quote currency is not evidence of the reporting currency (an ADR quotes
in USD and reports in TWD), so an unknown one is not guessed."""
out = _fundamentals({"longName": "X", "currency": "USD", "marketCap": 1000, "totalRevenue": 50})
assert "Market Cap: 1000 USD" in out and "Revenue (TTM): 50\n" in out + "\n"