github-mirrors/tradingagents
1
0
Fork 0
mirror of https://github.com/TauricResearch/TradingAgents.git synced 2026-11-04 00:22:43 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(yahoo): read a news article whose fields are null (#1458)

Browse Source 
- each article field falls back to its default on a null as well as on a missing key, so one malformed article no longer loses a ticker's news
This commit is contained in:
Yijia-Xiao
2026-10-03 21:27:43 +00:00
parent 99c79e6fb1
commit 9dceea6e9d
2 changed files with 58 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_news_lookahead.py
+30
View File
@@ -255,3 +255,33 @@ def test_the_article_limit_still_caps_what_is_returned(monkeypatch):
out = ynews.get_global_news_yfinance("2025-05-09", look_back_days=7, limit=3)
assert out.count("### ") == 3
@pytest.mark.unit
@pytest.mark.parametrize("field", ["title", "summary", "provider", "canonicalUrl", "pubDate"])
def test_an_article_with_a_null_field_is_read_with_its_default(field):
"""Yahoo sends some fields as null rather than leaving them out (#1458)."""
content = {"title": "T", "summary": "S", "provider": {"displayName": "P"},
"canonicalUrl": {"url": "https://x"}, "pubDate": "2026-09-22T10:00:00Z", field: None}
data = ynews._extract_article_data({"content": content})
assert isinstance(data["title"], str) and isinstance(data["summary"], str)
assert isinstance(data["publisher"], str) and isinstance(data["link"], str)
@pytest.mark.unit
@pytest.mark.parametrize("field", ["title", "summary", "publisher", "link"])
def test_a_flat_article_with_a_null_field_is_read_with_its_default(field):
data = ynews._extract_article_data({"title": "T", "summary": "S", "publisher": "P", "link": "L",
"providerPublishTime": _epoch("2026-09-22"), field: None})
assert all(isinstance(data[k], str) for k in ("title", "summary", "publisher", "link"))
@pytest.mark.unit
def test_one_malformed_article_does_not_lose_the_feed(monkeypatch):
good = {"content": {"title": "Kept", "summary": "", "provider": {"displayName": "Wire"},
"pubDate": "2026-09-22T10:00:00Z"}}
bad = {"content": {"title": "Also kept", "summary": None, "provider": None,
"pubDate": "2026-09-22T11:00:00Z"}}
_ticker_with([good, bad], monkeypatch)
out = ynews.get_news_yfinance("ZS", "2026-09-20", "2026-09-23")
assert "Kept" in out and "Also kept" in out