github-mirrors/tradingagents
1
0
Fork 0
mirror of https://github.com/TauricResearch/TradingAgents.git synced 2026-09-19 19:25:24 +03:00
Code Issues Packages Projects Releases Wiki Activity

chore: remove dead code found in the v0.4.0 review

Browse Source 
- inline _in_news_window, a trivial passthrough left from extracting
  dataflows.date_window.in_window; call in_window directly
- drop SignalProcessor's orphaned quick_thinking_llm attribute (unused since
  rating extraction became a deterministic parse)
This commit is contained in:
Yijia-Xiao
2026-08-31 01:29:14 +00:00
parent b43bc31479
commit a2f51da917
3 changed files with 14 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
tests/test_news_lookahead.py
View File

@@ -11,6 +11,7 @@ from datetime import datetime, timezone
import pytest
import tradingagents.dataflows.yfinance_news as ynews
from tradingagents.dataflows.date_window import in_window
def _epoch(date_str):
@@ -36,16 +37,16 @@ def test_window_excludes_future_and_undated_in_backtest():
end = datetime(2025, 5, 9) # historical window (well in the past)
inside = datetime(2025, 5, 5)
future = datetime(2025, 6, 1)
assert ynews._in_news_window(inside, start, end) is True
assert ynews._in_news_window(future, start, end) is False # look-ahead blocked
assert ynews._in_news_window(None, start, end) is False # undated -> excluded in backtest
assert in_window(inside, start, end) is True
assert in_window(future, start, end) is False # look-ahead blocked
assert in_window(None, start, end) is False # undated -> excluded in backtest
@pytest.mark.unit
def test_window_keeps_undated_in_live_window():
# Live window (reaches today): undated articles can't be "future", so keep them.
now = datetime.now(timezone.utc)
assert ynews._in_news_window(None, now, now) is True
assert in_window(None, now, now) is True
@pytest.mark.unit
@@ -56,8 +57,8 @@ def test_upper_bound_is_exclusive():
end = datetime(2025, 5, 9)
midnight_after = datetime(2025, 5, 10, 0, 0, 0, tzinfo=timezone.utc)
last_moment = datetime(2025, 5, 9, 23, 59, 59, tzinfo=timezone.utc)
assert ynews._in_news_window(midnight_after, start, end) is False
assert ynews._in_news_window(last_moment, start, end) is True
assert in_window(midnight_after, start, end) is False
assert in_window(last_moment, start, end) is True
@pytest.mark.unit
@@ -67,7 +68,7 @@ def test_offset_aware_timestamp_is_converted_not_truncated():
start = datetime(2025, 5, 1)
end = datetime(2025, 5, 9)
aware = datetime.fromisoformat("2025-05-10T01:00:00+05:00")
assert ynews._in_news_window(aware, start, end) is True
assert in_window(aware, start, end) is True
@pytest.mark.unit