fix(tools): hand vendors the model's dates as YYYY-MM-DD (#1488)

- as_of and as_of_window return canonical dates, so an unpadded date such as 2024-7-5 no longer compares as later than a filing dated 2024-07-24
- create_run_state validates the run date, as propagate does
This commit is contained in:
Yijia-Xiao
2026-10-27 07:57:32 +00:00
parent 2fe04cc771
commit a5b0f217e3
3 changed files with 27 additions and 8 deletions
+15
View File
@@ -28,6 +28,7 @@ TRADE_DATE = "2026-08-14"
(None, TRADE_DATE), # omitted
("Sept 1", TRADE_DATE), # unparseable
("", TRADE_DATE),
("2026-8-1", "2026-08-01"), # unpadded: served in its canonical form
])
def test_as_of_takes_the_earlier_date(requested, expected):
assert as_of(requested, TRADE_DATE) == expected
@@ -36,6 +37,7 @@ def test_as_of_takes_the_earlier_date(requested, expected):
@pytest.mark.unit
def test_as_of_without_a_trade_date_passes_the_request_through():
assert as_of("2026-09-14", "") == "2026-09-14"
assert as_of("2026-9-14", "") == "2026-09-14"
@pytest.mark.unit
@@ -43,6 +45,7 @@ def test_as_of_without_a_trade_date_passes_the_request_through():
("2026-08-01", "2026-09-14", ("2026-08-01", TRADE_DATE)), # end clamped
("2026-08-01", "2026-08-10", ("2026-08-01", "2026-08-10")), # inside: unchanged
("2026-09-01", "2026-09-08", ("2026-08-07", TRADE_DATE)), # wholly later: span kept, moved back
("2026-8-1", "2026-8-10", ("2026-08-01", "2026-08-10")), # unpadded: canonical
])
def test_as_of_window(start, end, expected):
assert as_of_window(start, end, TRADE_DATE) == expected
@@ -128,6 +131,16 @@ def test_future_window_from_the_model_is_clamped():
assert args == ("get_stock_data", "NVDA", "2026-08-01", TRADE_DATE)
@pytest.mark.unit
def test_an_unpadded_date_reaches_the_vendor_in_canonical_form():
# Vendors compare dates as YYYY-MM-DD text: "2026-07-23" > "2026-7-3" is False,
# so an unpadded date would let a filing made after it through.
args = _run(tools.get_income_statement, {"curr_date": "2026-7-3"}, tools)
assert args[-1] == "2026-07-03"
args = _run(tools.get_news, {"start_date": "2026-7-1", "end_date": "2026-7-3"}, tools)
assert args[-2:] == ("2026-07-01", "2026-07-03")
@pytest.mark.unit
def test_direct_call_without_state_is_unchanged():
with mock.patch.object(tools, "route_to_vendor", return_value="ok") as routed:
@@ -161,6 +174,8 @@ def test_propagate_rejects_a_non_canonical_date(bad):
with pytest.raises(ValueError, match="YYYY-MM-DD"):
object.__new__(TradingAgentsGraph).propagate("AAPL", bad)
with pytest.raises(ValueError, match="YYYY-MM-DD"): # the CLI starts a run here
object.__new__(TradingAgentsGraph).create_run_state("AAPL", bad)
@pytest.mark.unit