From f9d6495dcaea24f4a3eeec278d6b8a8183ee434a Mon Sep 17 00:00:00 2001
From: Yijia-Xiao <yijia-xiao@outlook.com>
Date: Thu, 24 Sep 2026 08:14:53 +0000
Subject: [PATCH] fix(fred): state the dates a macro change spans (#1397)

- the change line reads "Change from <first> to <last>" instead of "Change over window", so a partial-year move no longer reads as year on year
---
 tests/test_fred.py                      | 10 ++++++----
 tradingagents/dataflows/vendors/fred.py |  4 ++--
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/tests/test_fred.py b/tests/test_fred.py
index 6bcb6bbfc..c28c29891 100644
--- a/tests/test_fred.py
+++ b/tests/test_fred.py
@@ -98,8 +98,10 @@ class FredFormattingTests(unittest.TestCase):
         self.assertIn("Units: %", out)
         self.assertIn("Frequency: Monthly (SA)", out)
         self.assertIn("**Latest:** 4.4 (2025-09-01)", out)
-        # change over the window: 4.4 - 4.1 = +0.30
-        self.assertIn("+0.30", out)
+        # The change names the observations it spans, not the lookback window,
+        # so a 3-month move on a monthly series cannot read as year on year.
+        self.assertIn("**Change from 2025-06-01 to 2025-09-01:** +0.30 (+7.32%), from 4.1", out)
+        self.assertNotIn("Change over window", out)
         self.assertIn("| 2025-06-01 | 4.1 |", out)
 
     def test_missing_value_is_skipped(self):
@@ -133,8 +135,8 @@ class FredFormattingTests(unittest.TestCase):
         with mock.patch.object(fred, "_request", side_effect=_request_stub(obs=obs)):
             out = fred.get_macro_data("unemployment", "2025-12-31", 365)
         self.assertIn(f"most recent {fred.MAX_ROWS}", out)
-        # change-over-window must reference the true first (0) and last value
-        self.assertIn("from 0 ", out)
+        # the change must reference the true first (0) and last value
+        self.assertIn("+49.00, from 0\n", out)
         body_rows = [ln for ln in out.splitlines() if ln.startswith("| 2025")]
         self.assertEqual(len(body_rows), fred.MAX_ROWS)
 
diff --git a/tradingagents/dataflows/vendors/fred.py b/tradingagents/dataflows/vendors/fred.py
index 611d8d919..e5a130664 100644
--- a/tradingagents/dataflows/vendors/fred.py
+++ b/tradingagents/dataflows/vendors/fred.py
@@ -254,8 +254,8 @@ def get_macro_data(
         pct = f" ({delta / base * 100:+.2f}%)" if base != 0 else ""
         summary = (
             f"\n**Latest:** {last_val} ({last_date}) | "
-            f"**Change over window:** {delta:+.2f}{pct} "
-            f"from {first_val} ({first_date})\n"
+            f"**Change from {first_date} to {last_date}:** {delta:+.2f}{pct}, "
+            f"from {first_val}\n"
         )
     except ValueError:
         summary = f"\n**Latest:** {last_val} ({last_date})\n"