mirror of
https://github.com/TauricResearch/TradingAgents.git
synced 2026-06-16 21:06:15 +03:00
76add9048f
The CLI validated, normalized, and classified tickers with its own logic that diverged from the data layer: it rejected '=' symbols like GC=F (#980), classified BTCUSD as a stock (#981), and accepted unpriceable BTC-USDT (#982). Route the CLI through normalize_symbol (now mapping USDT/USDC crypto quotes to Yahoo's -USD pair), so validation, classification, and pricing agree.
63 lines
2.0 KiB
Python
63 lines
2.0 KiB
Python
"""CLI symbol validation/classification must agree with the data path.
|
|
|
|
Regressions for #980 (validation rejected GC=F), #981 (BTCUSD misclassified as
|
|
stock), #982 (BTC-USDT accepted but unpriceable on Yahoo).
|
|
"""
|
|
import pytest
|
|
|
|
from cli.models import AssetType
|
|
from cli.utils import detect_asset_type, is_valid_ticker_input, normalize_ticker_symbol
|
|
from tradingagents.dataflows.symbol_utils import normalize_symbol
|
|
|
|
|
|
# --- #982: stablecoin-quoted crypto normalizes to Yahoo's -USD pair ---
|
|
@pytest.mark.parametrize("raw,expected", [
|
|
("BTCUSD", "BTC-USD"),
|
|
("BTCUSDT", "BTC-USD"),
|
|
("BTC-USDT", "BTC-USD"),
|
|
("BTC-USDC", "BTC-USD"),
|
|
("ethusdt", "ETH-USD"),
|
|
# non-crypto must be untouched
|
|
("AAPL", "AAPL"),
|
|
("GC=F", "GC=F"),
|
|
("600519.SS", "600519.SS"),
|
|
("EURUSD", "EURUSD=X"),
|
|
])
|
|
def test_normalize_symbol_crypto_and_passthrough(raw, expected):
|
|
assert normalize_symbol(raw) == expected
|
|
|
|
|
|
# --- #980: validation accepts Yahoo futures/forex symbols ---
|
|
@pytest.mark.parametrize("value,ok", [
|
|
("GC=F", True),
|
|
("EURUSD=X", True),
|
|
("AAPL", True),
|
|
("0700.HK", True),
|
|
("^GSPC", True),
|
|
("", True), # empty -> defaults to SPY downstream
|
|
("bad symbol!", False), # space + '!' rejected
|
|
("A" * 40, False), # too long
|
|
])
|
|
def test_ticker_input_validation(value, ok):
|
|
assert is_valid_ticker_input(value) is ok
|
|
|
|
|
|
# --- #981/#982: asset-type classified on the canonical symbol ---
|
|
@pytest.mark.parametrize("raw,expected", [
|
|
("BTCUSD", AssetType.CRYPTO),
|
|
("BTC-USDT", AssetType.CRYPTO),
|
|
("BTC-USD", AssetType.CRYPTO),
|
|
("ETHUSD", AssetType.CRYPTO),
|
|
("AAPL", AssetType.STOCK),
|
|
("GC=F", AssetType.STOCK),
|
|
("600519.SS", AssetType.STOCK),
|
|
])
|
|
def test_detect_asset_type(raw, expected):
|
|
assert detect_asset_type(raw) == expected
|
|
|
|
|
|
def test_cli_normalize_delegates_to_data_layer():
|
|
# CLI must produce the same canonical symbol the data path will price.
|
|
for raw in ("XAUUSD", "BTCUSD", "btc-usdt", "AAPL"):
|
|
assert normalize_ticker_symbol(raw) == normalize_symbol(raw)
|