mirror of
https://github.com/TauricResearch/TradingAgents.git
synced 2026-09-19 19:25:24 +03:00
9b4c741d33
- reasoning_effort was forwarded only to IDs matching gpt-5 or the o-series, so GPT-6 models silently dropped the configured effort; match GPT-5 and later, with a version boundary so unrelated IDs do not match - Gemini Pro, 3.8+ and the -latest aliases reject thinking_level "minimal" with a 400; send it only to numbered Flash models before 3.8 and map it to "low" elsewhere, since aliases move between generations
44 lines
1.5 KiB
Python
44 lines
1.5 KiB
Python
"""OpenAI ``reasoning_effort`` is gated to reasoning models.
|
|
|
|
Non-reasoning OpenAI models (gpt-4.1, gpt-4o, ...) 400 with "Unsupported
|
|
parameter: 'reasoning.effort'". The client must drop the kwarg for those rather
|
|
than forward it and crash the run. The GPT-5 family and the o-series accept it.
|
|
"""
|
|
|
|
import pytest
|
|
|
|
from tradingagents.llm_clients.openai_client import (
|
|
OpenAIClient,
|
|
_supports_reasoning_effort,
|
|
)
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"model,expected",
|
|
[
|
|
("gpt-5.5", True), ("gpt-5.4", True), ("gpt-5.4-mini", True),
|
|
("gpt-5.5-pro", True), ("gpt-6-astra", True), ("o1", True), ("o3-mini", True),
|
|
("gpt-4.1", False), ("gpt-4o", False), ("gpt-4o-mini", False),
|
|
("gpt-3.5-turbo", False), ("gpt-10", True),
|
|
("gpt-5foo", False), ("gpt-60x", False), ("o3rd-party", False),
|
|
],
|
|
)
|
|
def test_supports_reasoning_effort(model, expected):
|
|
assert _supports_reasoning_effort(model) is expected
|
|
|
|
|
|
def _effort_on(model, monkeypatch):
|
|
# A fake key lets get_llm() construct the client without a network call.
|
|
monkeypatch.setenv("OPENAI_API_KEY", "test-key")
|
|
llm = OpenAIClient(model, provider="openai", reasoning_effort="low").get_llm()
|
|
return getattr(llm, "reasoning_effort", None)
|
|
|
|
|
|
def test_reasoning_model_receives_effort(monkeypatch):
|
|
assert _effort_on("gpt-5.4-mini", monkeypatch) == "low"
|
|
|
|
|
|
def test_non_reasoning_model_drops_effort(monkeypatch):
|
|
# gpt-4.1 would 400 with reasoning_effort — it must be dropped.
|
|
assert _effort_on("gpt-4.1", monkeypatch) is None
|