mirror of
https://github.com/nestriness/nestri.git
synced 2026-09-19 17:25:19 +03:00
Second half of G1's "neslet registers against api.nestri.io and heartbeats".
Registration already worked; there was no heartbeat endpoint at all — grep for
it across apps/api and packages/core returned nothing, and neslet's own
main.rs says the same from its side.
POST /machine/heartbeat, machine credentials only. Two decisions worth stating
because neither is obvious from the diff:
**It returns the interval.** The auth middleware already touches lastSeen on
every authenticated machine request, so an endpoint that only did that would
add an endpoint and no capability. What a host cannot know on its own is how
often the control plane wants to hear from it, so the response carries the
cadence. A fleet whose interval can only change by shipping a new agent is a
fleet whose interval never changes.
**It takes no body.** neslet has a HostSummary ready to send, and week 2 owns
box state reporting. Accepting fields nothing acts on yet would mean a wire
shape we would have to keep, chosen before the thing that consumes it exists.
Online-ness is derived from lastSeen rather than stored: a host that stops
beating goes offline through the passage of time, which is the one mechanism
that cannot itself fail. Three missed beats, not one — a single missed beat is
a lost packet, and treating that as offline would make placement flap.
Also: the machine actor's teamID stops being optional. It was `...(teamId ? {}
: {})` in the middleware, a branch for a state that cannot exist now that
machine.team_id is notNull.
134 tests, 0 fail.
312 lines
9.5 KiB
TypeScript
312 lines
9.5 KiB
TypeScript
import { Actor } from '@nestri/core/actor';
|
||
import { ErrorCodes, VisibleError } from '@nestri/core/error';
|
||
import { Examples } from '@nestri/core/examples';
|
||
import { Identifier } from '@nestri/core/id';
|
||
import { Machine } from '@nestri/core/machine/index';
|
||
import { Member } from '@nestri/core/team/member';
|
||
import { Team } from '@nestri/core/team/index';
|
||
import { Hono } from 'hono';
|
||
import { describeRoute } from 'hono-openapi';
|
||
import { z } from 'zod';
|
||
|
||
import { ErrorResponses, machineOnly, notPublic, Result, validator } from '../utils';
|
||
|
||
/**
|
||
* Host registration.
|
||
*
|
||
* A box does not get to say who it is. It registers once against its owner's
|
||
* session, is handed an id and a secret, and authenticates as itself from then
|
||
* on — so `hostId` on a download report is something the API assigned rather
|
||
* than a free-form string any holder of a shared secret could invent.
|
||
*/
|
||
export namespace MachineApi {
|
||
export const route = new Hono()
|
||
.post(
|
||
'/register',
|
||
notPublic,
|
||
describeRoute({
|
||
tags: ['Machine'],
|
||
summary: 'Register a nessh host',
|
||
description:
|
||
'Exchange the calling user session for a machine id and secret. The secret is returned once and never again — it is stored only as a digest.',
|
||
responses: {
|
||
200: {
|
||
content: {
|
||
'application/json': {
|
||
schema: Result(
|
||
z.object({
|
||
machineId: z.string().meta({ example: Examples.Machine.id }),
|
||
secret: z.string().meta({
|
||
description: 'Shown once. Store it on the box; it cannot be retrieved.'
|
||
})
|
||
})
|
||
)
|
||
}
|
||
},
|
||
description: 'The box is registered'
|
||
},
|
||
401: ErrorResponses[401],
|
||
403: ErrorResponses[403]
|
||
}
|
||
}),
|
||
validator(
|
||
'json',
|
||
z.object({
|
||
label: z.string().min(1).max(64).meta({
|
||
description: 'Human-readable name for the box',
|
||
example: Examples.Machine.label
|
||
}),
|
||
teamId: z.string().optional().meta({
|
||
description:
|
||
'Team to own this hardware. Defaults to the caller’s personal team, which always exists'
|
||
})
|
||
})
|
||
),
|
||
async (c) => {
|
||
const { label, teamId } = c.req.valid('json');
|
||
|
||
// `notPublic` also admits admin, which has no user to own the box.
|
||
// Registering is an act of ownership, so it needs a real one.
|
||
const actor = Actor.use();
|
||
if (actor.type !== 'user' && actor.type !== 'member') {
|
||
throw new VisibleError(
|
||
'forbidden',
|
||
ErrorCodes.Permission.INSUFFICIENT_PERMISSIONS,
|
||
'Registering a machine requires a user session'
|
||
);
|
||
}
|
||
|
||
// `machine.teamId` is notNull since 0048, so a team has to be
|
||
// resolved rather than defaulted to null. The order is: what the
|
||
// caller asked for, then the team they are acting inside, then
|
||
// their personal team — which `ensurePersonal` makes if this is a
|
||
// user who predates 0048 and has none.
|
||
const owningTeam =
|
||
teamId ??
|
||
(actor.type === 'member'
|
||
? actor.properties.teamID
|
||
: await Team.ensurePersonal({ displayName: Actor.userID }));
|
||
|
||
// A caller naming a team must belong to it. Without this, `teamId`
|
||
// would be a way to park hardware in somebody else's team.
|
||
if (teamId) {
|
||
const membership = await Member.findByTeamAndUser({
|
||
teamId,
|
||
userId: Actor.userID
|
||
});
|
||
if (!membership) {
|
||
throw new VisibleError(
|
||
'forbidden',
|
||
ErrorCodes.Permission.FORBIDDEN,
|
||
'You are not a member of that team'
|
||
);
|
||
}
|
||
}
|
||
|
||
const registered = await Machine.register({
|
||
id: Identifier.ascending('machine'),
|
||
ownerUserId: Actor.userID,
|
||
teamId: owningTeam,
|
||
label
|
||
});
|
||
|
||
return c.json({ data: { machineId: registered.id, secret: registered.secret } });
|
||
}
|
||
)
|
||
.patch(
|
||
'/:id',
|
||
notPublic,
|
||
describeRoute({
|
||
tags: ['Machine'],
|
||
summary: 'Move a box to another team',
|
||
description:
|
||
'Move a machine you own to a team you belong to. Hardware always belongs to exactly one team since 0048, so there is no way to unscope — name your personal team instead. This is not ownership transfer: the owner does not change.',
|
||
responses: {
|
||
200: {
|
||
content: { 'application/json': { schema: Result(Machine.Info) } },
|
||
description: 'The machine, rescoped'
|
||
},
|
||
401: ErrorResponses[401],
|
||
403: ErrorResponses[403],
|
||
404: ErrorResponses[404]
|
||
}
|
||
}),
|
||
validator(
|
||
'json',
|
||
z.object({
|
||
teamId: z.string().meta({
|
||
description:
|
||
'Team to move the box to. There is no “no team” — to unscope, name your personal team'
|
||
})
|
||
})
|
||
),
|
||
async (c) => {
|
||
const { teamId } = c.req.valid('json');
|
||
|
||
const actor = Actor.use();
|
||
if (actor.type !== 'user' && actor.type !== 'member') {
|
||
throw new VisibleError(
|
||
'forbidden',
|
||
ErrorCodes.Permission.INSUFFICIENT_PERMISSIONS,
|
||
'Rescoping a machine requires a user session'
|
||
);
|
||
}
|
||
|
||
// Verified before the write. `setTeam` scopes to the owner but
|
||
// knows nothing about who belongs to the target team, so this is
|
||
// the only place that check exists.
|
||
const membership = await Member.findByTeamAndUser({
|
||
teamId,
|
||
userId: Actor.userID
|
||
});
|
||
if (!membership) {
|
||
throw new VisibleError(
|
||
'forbidden',
|
||
ErrorCodes.Permission.FORBIDDEN,
|
||
'You are not a member of that team'
|
||
);
|
||
}
|
||
|
||
const machine = await Machine.setTeam({
|
||
id: c.req.param('id'),
|
||
ownerUserId: Actor.userID,
|
||
teamId
|
||
});
|
||
if (!machine) {
|
||
// Owner-scoped in the query, so someone else's machine is a
|
||
// 404 rather than a 403 — no way to probe for ids.
|
||
throw new VisibleError(
|
||
'not_found',
|
||
ErrorCodes.NotFound.RESOURCE_NOT_FOUND,
|
||
'No such machine, or it is not yours'
|
||
);
|
||
}
|
||
return c.json({ data: machine });
|
||
}
|
||
)
|
||
.get(
|
||
'/entitlement',
|
||
machineOnly,
|
||
describeRoute({
|
||
tags: ['Machine'],
|
||
summary: 'Ask whether a user may use this box',
|
||
description:
|
||
'Answers for the calling machine only — the machine is taken from its credentials, never from the query, so a box cannot ask about another. Membership is read live, so removing someone from a team removes their access.',
|
||
responses: {
|
||
200: {
|
||
content: { 'application/json': { schema: Result(Machine.Entitlement) } },
|
||
description: 'Whether the user may use this machine, and why'
|
||
},
|
||
403: ErrorResponses[403]
|
||
}
|
||
}),
|
||
validator('query', z.object({ userId: z.string().min(1) })),
|
||
async (c) => {
|
||
const { userId } = c.req.valid('query');
|
||
return c.json({
|
||
data: await Machine.entitlement({ machineId: Actor.machineID, userId })
|
||
});
|
||
}
|
||
)
|
||
.post(
|
||
'/heartbeat',
|
||
machineOnly,
|
||
describeRoute({
|
||
tags: ['Machine'],
|
||
summary: 'Say the host is alive',
|
||
description:
|
||
'Records liveness for the calling machine and returns how often it should call back. The interval comes from the server on purpose: a fleet whose cadence can only change by shipping a new agent is a fleet whose cadence never changes. Takes no body — what a host is *running* is reported separately, and reporting a shape we cannot yet act on would be worse than reporting nothing.',
|
||
responses: {
|
||
200: {
|
||
content: {
|
||
'application/json': {
|
||
schema: Result(
|
||
z.object({
|
||
lastSeen: z.iso.datetime().meta({
|
||
description: 'When this beat was recorded, by the database’s clock',
|
||
example: Examples.Machine.lastSeen
|
||
}),
|
||
intervalSeconds: z.number().meta({
|
||
description: 'Call back this often',
|
||
example: Machine.HEARTBEAT_SECONDS
|
||
})
|
||
})
|
||
)
|
||
}
|
||
},
|
||
description: 'The beat was recorded'
|
||
},
|
||
403: ErrorResponses[403],
|
||
404: ErrorResponses[404]
|
||
}
|
||
}),
|
||
async (c) => {
|
||
const lastSeen = await Machine.touchLastSeen(Actor.machineID);
|
||
if (!lastSeen) {
|
||
// The credentials authenticated but the row is gone — a host
|
||
// deleted mid-beat. It must re-register rather than keep
|
||
// beating into nothing, so this is a 404 and not a 200.
|
||
throw new VisibleError(
|
||
'not_found',
|
||
ErrorCodes.NotFound.RESOURCE_NOT_FOUND,
|
||
'This machine no longer exists'
|
||
);
|
||
}
|
||
return c.json({
|
||
data: {
|
||
lastSeen: lastSeen.toISOString(),
|
||
intervalSeconds: Machine.HEARTBEAT_SECONDS
|
||
}
|
||
});
|
||
}
|
||
)
|
||
.get(
|
||
'/me',
|
||
machineOnly,
|
||
describeRoute({
|
||
tags: ['Machine'],
|
||
summary: 'Describe the calling machine',
|
||
description:
|
||
'Returns the registration record for the credentials used. A box calls this at startup to confirm its credentials still work before relying on them.',
|
||
responses: {
|
||
200: {
|
||
content: { 'application/json': { schema: Result(Machine.Info) } },
|
||
description: 'The calling machine'
|
||
},
|
||
403: ErrorResponses[403],
|
||
404: ErrorResponses[404]
|
||
}
|
||
}),
|
||
async (c) => {
|
||
const machine = await Machine.fromID(Actor.machineID);
|
||
if (!machine) {
|
||
throw new VisibleError(
|
||
'not_found',
|
||
ErrorCodes.NotFound.RESOURCE_NOT_FOUND,
|
||
'This machine no longer exists'
|
||
);
|
||
}
|
||
return c.json({ data: machine });
|
||
}
|
||
)
|
||
.get(
|
||
'/',
|
||
notPublic,
|
||
describeRoute({
|
||
tags: ['Machine'],
|
||
summary: 'List your registered hosts',
|
||
responses: {
|
||
200: {
|
||
content: { 'application/json': { schema: Result(z.array(Machine.Info)) } },
|
||
description: 'Machines owned by the caller'
|
||
},
|
||
401: ErrorResponses[401],
|
||
403: ErrorResponses[403]
|
||
}
|
||
}),
|
||
async (c) => {
|
||
return c.json({ data: await Machine.listByOwner(Actor.userID) });
|
||
}
|
||
);
|
||
}
|