mirror of
https://github.com/TauricResearch/TradingAgents.git
synced 2026-09-27 15:02:39 +03:00
131 lines
4.5 KiB
Python
131 lines
4.5 KiB
Python
"""A Yahoo rate limit is retried, then reported as a rate limit.
|
|
|
|
When the limit outlasts the retries, the agent must hear that the vendor is
|
|
throttled. "The symbol may be invalid or delisted" is a claim about the company
|
|
that nobody checked, and an exception out of a tool ends the run.
|
|
"""
|
|
|
|
import pandas as pd
|
|
import pytest
|
|
import yfinance as yf
|
|
from yfinance.data import YfData
|
|
from yfinance.exceptions import YFRateLimitError
|
|
|
|
from tradingagents.agents.tools import (
|
|
get_global_news,
|
|
get_indicators,
|
|
get_insider_transactions,
|
|
get_news,
|
|
get_stock_data,
|
|
get_verified_market_snapshot,
|
|
)
|
|
from tradingagents.dataflows import router
|
|
from tradingagents.dataflows.config import set_config
|
|
from tradingagents.dataflows.errors import NoMarketDataError, VendorRateLimitError
|
|
from tradingagents.dataflows.vendors.yahoo import fundamentals, ohlcv
|
|
|
|
DAY = "2026-09-18"
|
|
|
|
|
|
def _rate_limited(*args, **kwargs):
|
|
raise YFRateLimitError()
|
|
|
|
|
|
@pytest.fixture
|
|
def yahoo(monkeypatch, tmp_path):
|
|
set_config({"data_cache_dir": str(tmp_path)})
|
|
monkeypatch.setattr(ohlcv.time, "sleep", lambda seconds: None)
|
|
for module in (ohlcv, fundamentals):
|
|
monkeypatch.setattr(module, "vendor_reachable", lambda url: True)
|
|
return monkeypatch
|
|
|
|
|
|
@pytest.mark.unit
|
|
@pytest.mark.parametrize("tool, args", [
|
|
pytest.param(get_stock_data, ("AAPL", "2026-09-10", DAY), id="stock_data"),
|
|
pytest.param(get_indicators, ("AAPL", "rsi", DAY, 5), id="indicators"),
|
|
pytest.param(get_verified_market_snapshot, ("AAPL", DAY), id="snapshot"),
|
|
pytest.param(get_news, ("AAPL", "2026-09-10", DAY), id="news"),
|
|
pytest.param(get_global_news, (DAY, 7, 5), id="global_news"),
|
|
pytest.param(get_insider_transactions, ("AAPL",), id="insider"),
|
|
])
|
|
def test_a_rate_limit_that_outlasts_the_retries_is_reported_as_one(yahoo, tool, args):
|
|
for name in ("history", "get_news"):
|
|
yahoo.setattr(yf.Ticker, name, _rate_limited)
|
|
yahoo.setattr(yf.Ticker, "insider_transactions", property(_rate_limited))
|
|
yahoo.setattr(yf, "Search", _rate_limited)
|
|
|
|
out = tool.func(*args, trade_date=DAY)
|
|
|
|
assert out.startswith("DATA_UNAVAILABLE"), out
|
|
assert "delisted" not in out
|
|
|
|
|
|
@pytest.mark.unit
|
|
def test_the_indicator_path_retries_a_rate_limit(yahoo):
|
|
"""The prices behind every indicator were fetched with ``yf.download``, which
|
|
returns an empty frame for a 429, so they were never retried."""
|
|
bar = pd.DataFrame({"Open": [1.0], "High": [1.0], "Low": [1.0], "Close": [1.0],
|
|
"Volume": [100]}, index=pd.DatetimeIndex([DAY], name="Date"))
|
|
answers = [YFRateLimitError(), bar]
|
|
|
|
def history(self, **kwargs):
|
|
answer = answers.pop(0)
|
|
if isinstance(answer, Exception):
|
|
raise answer
|
|
return answer
|
|
|
|
yahoo.setattr(yf.Ticker, "history", history)
|
|
|
|
assert ohlcv.load_ohlcv("AAPL", DAY)["Close"].tolist() == [1.0]
|
|
|
|
|
|
@pytest.mark.unit
|
|
def test_yfinance_raises_the_rate_limit_from_history(yahoo):
|
|
yahoo.setattr(YfData, "_make_request", _rate_limited)
|
|
|
|
with pytest.raises(VendorRateLimitError, match="rate limited"):
|
|
ohlcv.load_ohlcv("AAPL", DAY)
|
|
|
|
|
|
@pytest.mark.unit
|
|
def test_fundamentals_ask_a_new_ticker_after_a_rate_limit(yahoo):
|
|
"""A Ticker keeps a failed ``info`` fetch as done, so asking the same one
|
|
again reads an empty profile, which looks like a symbol with no data."""
|
|
|
|
class Ticker:
|
|
def __init__(self, symbol):
|
|
self.fetched = False
|
|
|
|
@property
|
|
def info(self):
|
|
if self.fetched:
|
|
return {}
|
|
self.fetched = True
|
|
raise YFRateLimitError()
|
|
|
|
yahoo.setattr(yf, "Ticker", Ticker)
|
|
|
|
out = router.route_to_vendor("get_fundamentals", "AAPL", None)
|
|
|
|
assert out.startswith("DATA_UNAVAILABLE"), out
|
|
|
|
|
|
@pytest.mark.unit
|
|
def test_another_price_fetch_error_still_tells_an_outage_from_an_unknown_symbol(yahoo):
|
|
"""``Ticker.history`` lets some errors through that ``yf.download`` turned
|
|
into an empty frame. Whether Yahoo answers still decides which one it is."""
|
|
|
|
def refused(self, **kwargs):
|
|
raise ConnectionError("curl: (7) Failed to connect to query2.finance.yahoo.com")
|
|
|
|
yahoo.setattr(yf.Ticker, "history", refused)
|
|
|
|
yahoo.setattr(ohlcv, "vendor_reachable", lambda url: False)
|
|
with pytest.raises(VendorRateLimitError, match="unreachable"):
|
|
ohlcv.load_ohlcv("AAPL", DAY)
|
|
|
|
yahoo.setattr(ohlcv, "vendor_reachable", lambda url: True)
|
|
with pytest.raises(NoMarketDataError):
|
|
ohlcv.load_ohlcv("AAPL", DAY)
|